Fix expm1 for complex special cases #1332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpctl/tensor/libtensor/include/kernels/elementwise_functions/expm1.hpp
Outdated
Show resolved
Hide resolved
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1332/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_3 ran successfully. |
ndgrigorian
force-pushed
the
expm1-special-cases
branch
from
f3edac3 to
64282d6
Compare
|
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_33 ran successfully. |
dpctl/tensor/libtensor/include/kernels/elementwise_functions/expm1.hpp
Outdated
Show resolved
Hide resolved
For `inf` real part and finite, nonzero imaginary part, now guaranteed to be (+/-`inf`, +/-`inf`), with cosine and sine of the imaginary part determining the sign, respectively
oleksandr-pavlyk
approved these changes
Aug 10, 2023
|
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_38 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev1=py310h7bf5fec_34 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the logic of
expm1for complex data types to better account for special cases (NaNs,infs, etc.). These cases were handled identically to Numpy, but did not conform to the array API.In addition, this PR slips in changes to silence the remaining warnings in the test suite which were being raised by the elementwise tests.