Fixed tests from_dlpack and _from_dlpack_strided for USM-host allocations #1338
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cations Since USM-host allocation, unlike USM-device and USM-shared allocations, is not associated with any particular device, only with the host, it is unreasonable to expect that sycl::get_pointer_device(ptr, ctx) will return the same device that is stored in the sycl_queue associated with the dpctl.tensor.usm_ndarray. The tests are adjusted to bypass that check for USM-host allocations.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1338/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev2=py310h7bf5fec_2 ran successfully. |
|
SYCL spec for The |
ndgrigorian
approved these changes
Aug 15, 2023
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev2=py310h7bf5fec_6 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since USM-host allocation, unlike USM-device and USM-shared allocations, is not associated with any particular device, only with the host, it is unreasonable to expect that
sycl::get_pointer_device(ptr, ctx)will return the same device that is stored in thesycl_queueattribute ofdpctl.tensor.usm_ndarrayinstance.The tests are adjusted to bypass that check for USM-host allocations.