Skip to content

Do not build dpctl for Python 3.8 #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Do not build dpctl for Python 3.8 #1363

merged 3 commits into from
Aug 23, 2023

Conversation

oleksandr-pavlyk
Copy link
Contributor

Closes gh-1295

Stop building conda packages of dpctl for Python 3.8

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Since numba-dpex has dropped Py 3.8 from its matrix of builds, we can do
the same now with dpnp to follow.
Also install ninja from pip instead of apt.
@coveralls
Copy link
Collaborator

coveralls commented Aug 23, 2023

Coverage Status

coverage: 85.636%. remained the same when pulling 6f22fa0 on drop-py-3.8 into 3cbb221 on master.

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_10 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

antonwolfy
antonwolfy previously approved these changes Aug 23, 2023
Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've opened a PR in dpnp with similar changes. Thank you @oleksandr-pavlyk for driving that !

@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_11 ran successfully.
Passed: 916
Failed: 84
Skipped: 119

@oleksandr-pavlyk oleksandr-pavlyk merged commit d85e130 into master Aug 23, 2023
@oleksandr-pavlyk oleksandr-pavlyk deleted the drop-py-3.8 branch August 23, 2023 12:59
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop support for Python 3.8 in GH action conda-packages.yaml workflow
3 participants