Addressed "Very high" Coverity issue: dereferencing null pointer #1369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensured that `create_property_list` always returns an not-null unique pointer by creating an default-constructed property_list for the fall-through. With this change we no longer need to branches for call to sycl::queue constructor, since propList is always available.
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/1369/index.html |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_15 ran successfully. |
oleksandr-pavlyk
changed the title
ndgrigorian
previously approved these changes
Aug 26, 2023
oleksandr-pavlyk
changed the title
diptorupd
reviewed
Aug 28, 2023
diptorupd
reviewed
Aug 28, 2023
| @@ -143,6 +143,9 @@ std::unique_ptr<property_list> create_property_list(int properties) | |||
| propList = | |||
| std::make_unique<property_list>(sycl::property::queue::in_order()); | |||
| } | |||
| else { | |||
There was a problem hiding this comment.
I was not aware SYCL runtime allows an empty property_list. The change is good.
Remove unneeded static keyword in definition of create_property_list function in anonymous namespace
diptorupd
approved these changes
Aug 28, 2023
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_29 ran successfully. |
oleksandr-pavlyk
deleted the
fix-coverity-issue-in-dpctl-sycl-queue-interface
branch
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.6dev4=py310ha25a700_29 ran successfully. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensured that
create_property_listalways returns an not-null unique pointer by creating an default-constructedproperty_listfor the fall-through.With this change we no longer need two branches for call to
sycl::queueconstructor, sincepropListis always available.