Skip to content

No reason to expected ufunc.types_ to be None. #1515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Encountered unexpected test failure using the following test invocation:

python -m pytest \
   dpctl/tests/test_tensor_*.py \
   dpctl/tests/test_usm_ndarray_*.py \
   dpctl/tests/elementwise/test_a*.py
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Jan 29, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

coveralls commented Jan 29, 2024

Coverage Status

coverage: 91.0%. remained the same
when pulling 8d72b07 on fix-types-property-test
into 86aaede on master.

Copy link

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_44 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

@ndgrigorian
Copy link
Collaborator

This is a good change, but it may make more sense to remove that line altogether.
It was added there to test that caching of types takes place (starts at None, is set afterward), but was malformed.

Example where that assumption is wrong is the following test invocation:

```
python -m pytest \
   dpctl/tests/test_tensor_*.py \
   dpctl/tests/test_usm_ndarray_*.py \
   dpctl/tests/elementwise/test_a*.py
```

Removed test of `uf.types_` to be `None` altogether per PR feedback.
@oleksandr-pavlyk
Copy link
Contributor Author

@ndgrigorian I have push the change to remove testing of .types_ attribute altogether, and renamed test_abs_types_prop to test_abs_types_property to stay consistent with name in test_add.py.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 11a933e into master Jan 30, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-types-property-test branch January 30, 2024 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants