Skip to content

Change array-api-tests run command #1523

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Feb 1, 2024

Change array-api-tests run command.

This should resolve the following ModuleNotFoundError seen in the logs:

Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/work/dpctl/dpctl/dpctl/__init__.py", line 38, in <module>
    from ._device_selection import select_device_with_aspects
  File "/home/runner/work/dpctl/dpctl/dpctl/_device_selection.py", line 20, in <module>
    from ._sycl_device import SyclDevice, SyclDeviceCreationError
ModuleNotFoundError: No module named 'dpctl._sycl_device'
============================= test session starts ==============================
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

This should resolve the following ModuleNotFoundError seen in the logs:

```
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/home/runner/work/dpctl/dpctl/dpctl/__init__.py", line 38, in <module>
    from ._device_selection import select_device_with_aspects
  File "/home/runner/work/dpctl/dpctl/dpctl/_device_selection.py", line 20, in <module>
    from ._sycl_device import SyclDevice, SyclDeviceCreationError
ModuleNotFoundError: No module named 'dpctl._sycl_device'
============================= test session starts ==============================
```
Copy link

github-actions bot commented Feb 1, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.065%. remained the same
when pulling 979a30c on fix-conformity-test-step-run-command
into 1015fcf on master.

Copy link

github-actions bot commented Feb 1, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_60 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review February 2, 2024 00:33
Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good catch

@oleksandr-pavlyk oleksandr-pavlyk merged commit 847f93d into master Feb 2, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-conformity-test-step-run-command branch February 2, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants