Skip to content

Added work-around for breaking change in 2024.1 compiler #1532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

oleksandr-pavlyk
Copy link
Contributor

"OpenCL:CPU" device started reporting aspect::fp16 and supporting sycl::half type, but vector widths for sycl::half type both return zero.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

OpenCL:CPU device started reporting aspect::fp16, but vector
widths for sycl::half type both return zero.
Copy link

github-actions bot commented Feb 7, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.145%. remained the same
when pulling fbd68b8 on fix-test-sycl-device-interface-for-future-dpcpp
into e2d9640 on master.

Copy link

github-actions bot commented Feb 7, 2024

Array API standard conformance tests for dpctl=0.15.1dev3=py310h15de555_92 ran successfully.
Passed: 909
Failed: 0
Skipped: 86

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 71b1640 into master Feb 7, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-test-sycl-device-interface-for-future-dpcpp branch February 7, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants