Skip to content

Removed _gemm_batch_old_nm_impl, got rid of using _new_, _old_ in names #1546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 14, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR replaced uses of _old_nm_ functions with _new_nm_ functions, and then removed GemmBatchFunctorThreadNM and the _old_nm_ unused functions.

After this all _new_ and _old_ parts in the functions names were deleted.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Feb 13, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 91.138%. remained the same
when pulling f62ba25 on futher-gemm-code-cleanup
into 275138b on master.

Copy link

Array API standard conformance tests for dpctl=0.16.0dev0=py310h15de555_6 ran successfully.
Passed: 906
Failed: 3
Skipped: 86

Copy link
Collaborator

@ndgrigorian ndgrigorian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this compared to master, I don't see a significant performance change.

LGTM!

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3778516 into master Feb 14, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the futher-gemm-code-cleanup branch February 14, 2024 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants