Adds and implements utilities for validating array size and writable flag #1547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These checks are implemented through a new CheckWritable struct, which has a static method throw_if_not_writable, which throws if an array is read-only
ndgrigorian
changed the title
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
The check for sufficiently ample memory was performed with the incorrect operand
|
Array API standard conformance tests for dpctl=0.16.0dev0=py310h15de555_7 ran successfully. |
oleksandr-pavlyk
approved these changes
Feb 14, 2024
|
Array API standard conformance tests for dpctl=0.16.0dev0=py310h15de555_8 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request refactors Python API functions to use new utilities for validating output arrays. These utilities validate that an array is sufficiently ample for a given number of elements (i.e., not the result of broadcasting) and that the array's writable flag is set.