Skip to content

Used DPCTLQueue_MemoryWithEvent to order copy operations #1591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 12, 2024
Merged

Used DPCTLQueue_MemoryWithEvent to order copy operations #1591

merged 1 commit into from
Mar 12, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Used DPCTLQueue_MemoryWithEvent to order copy operations in copy_via_host function.

This eliminates one call to DPCTLEvent_Wait.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@oleksandr-pavlyk
Used DPCTLQueue_MemoryWithEvent to order copy operations
f56f128 
This eliminates one call to `DPCTLEvent_Wait`.
@oleksandr-pavlyk oleksandr-pavlyk force-pushed the memory-copy-via-host-get-rid-of-one-wait branch from ec0ec42 to f56f128 Compare March 11, 2024 20:14
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 11, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.832% (+0.001%) from 87.831%
when pulling f56f128 on memory-copy-via-host-get-rid-of-one-wait
into 5f08828 on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_104 ran successfully.
Passed: 906
Failed: 0
Skipped: 94

@oleksandr-pavlyk oleksandr-pavlyk merged commit 653870b into master Mar 12, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the memory-copy-via-host-get-rid-of-one-wait branch March 12, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @ndgrigorian