Skip to content

Renamed argument of DPCTLPlatform_Hash to match doxygen doc string #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

Renamed argument of DPCTLPlatform_Hash to match doxygen doc string #1592

merged 1 commit into from
Mar 14, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Inspecting documentation building log noticed mismatch between doxygen doc-string and actual declaration.

This PR fixes the mismatch.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 14, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.832%. remained the same
when pulling 1940f45 on fix-doxygen-selfdoc-comment
into 653870b on master.

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_106 ran successfully.
Passed: 905
Failed: 1
Skipped: 94

@oleksandr-pavlyk oleksandr-pavlyk merged commit 4be843a into master Mar 14, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the fix-doxygen-selfdoc-comment branch March 14, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diptorupd diptorupd diptorupd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleksandr-pavlyk @coveralls @diptorupd