Skip to content

Backport gh 1558 to 0.16.x maintenance branch #1612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 13 commits into from
Mar 27, 2024
Merged

Backport gh 1558 to 0.16.x maintenance branch #1612

merged 13 commits into from
Mar 27, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

This PR backports gh-1558 to 'maintenance/0.16.x'. This PR completes the sequence of backports intended for 0.16.1 bug fix release.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Diptorup Deb and others added 13 commits March 27, 2024 11:08
@oleksandr-pavlyk
Support local_accessor kernel arguments.
a66d3ec 
    - Adds support in libsyclinterface:: dpctl_sycl_queue_interface for
      sycl::local_accessor as kernel arguments.
    - Refactoring to get rid of compiler warnings.
@oleksandr-pavlyk
Add unit tests for local accessor kernel arg.
cf42308
@oleksandr-pavlyk
Remove leftover class from enum_types.__all__
ce81aeb
@oleksandr-pavlyk
Add local_accessor kernel_arg_type
20fd9e0
@oleksandr-pavlyk
Improve coverage of dpctl_sycl_queue_interface
1988ad8 
Test submit for 1D range, 2D range, and 3D range, and also
specify dependent events.
@oleksandr-pavlyk
host is no longer a valid string selector
5a00660
@oleksandr-pavlyk
Add test for DPCTLQueue_Create for some nullptr args
a72c004
@oleksandr-pavlyk
Only run test submit if device has aspect fp64
1919fc6
@oleksandr-pavlyk
Test Local accessor for ndim=1, 2, 3
63eb219
@oleksandr-pavlyk
Renamed target llvm-cov to llvm-cov-report, added target llvm-cov-show
95c41c1 
The llvm-cov-report outputs the coverage summary, while llvm-cov-show
displays per-line coverage statistics to identify missed lines.
@oleksandr-pavlyk
Update to dbg_build
bac2cb4 
Let LLVM_TOOLS_HOME and PATH to make llvm-cov, and llvm-profdata
discoverable by cmake.
@oleksandr-pavlyk
Change script to use llvm-cov-report instead of llvm-cov
cf94017
@oleksandr-pavlyk
Moved typedef for MDLocalAccessor to dpctl_sycl_queue_interface.hpp
733bc32
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 27, 2024 •
edited
Loading

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions GitHub Actions
Copy link

Array API standard conformance tests for dpctl=0.16.0=py310h15de555_46 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Mar 27, 2024
Merged
6 tasks
@oleksandr-pavlyk oleksandr-pavlyk merged commit faf965c into maintenance/0.16.x Mar 27, 2024
@oleksandr-pavlyk oleksandr-pavlyk deleted the backport-gh-1558-take2 branch March 27, 2024 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndgrigorian ndgrigorian ndgrigorian approved these changes

@diptorupd diptorupd Awaiting requested review from diptorupd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @ndgrigorian