Skip to content

Edit docstrings for tile and repeat, fix "usm_narray" typos #1629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 2, 2024

Conversation

ndgrigorian
Copy link
Collaborator

@ndgrigorian ndgrigorian commented Apr 1, 2024

This PR changes docstrings for tile and repeat to better describe behaviors of these functions, and fixes minor typos throughout dpctl where "usm_narray" was used instead of "usm_ndarray"

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

Copy link

github-actions bot commented Apr 1, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Apr 1, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_189 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@ndgrigorian ndgrigorian changed the title Edit docstrings for tile and repeat, fix usm_narray typos Edit docstrings for tile and repeat, fix "usm_narray" typos Apr 1, 2024
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for finding and fixing these @ndgrigorian !

Copy link

github-actions bot commented Apr 2, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_190 ran successfully.
Passed: 839
Failed: 0
Skipped: 92

@ndgrigorian ndgrigorian merged commit dd1da6b into docstring-edits-only Apr 2, 2024
oleksandr-pavlyk pushed a commit that referenced this pull request Apr 4, 2024
* Improves `tile` docstring

* Improves `repeat` docstring

* Fixed typos in `angle` and `reciprocal` docstrings

* Fixed typos in docstrings for `permute_dims, `moveaxis`, and `swapaxes`

* Fixes typo and grammar in `nonzero` docstring

* Fixes a typo in `populate_params` in `blackscholes.pyx` example

* Change to `broadcast-compatible` per PR review by @oleksandr-pavlyk
@oleksandr-pavlyk oleksandr-pavlyk deleted the tile-repeat-docstring-changes branch April 4, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants