Skip to content

Unmute prod tests muted for 2024.0 compiler #1633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This PR unmutes some tests for prod which were being skipped due to 2024.0 compiler issues with prod reduction for complex data types.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

These tests were skipped due to 2024.0 compiler issues. With 2024.1 compiler, this should no longer be an issue
Copy link

github-actions bot commented Apr 3, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

github-actions bot commented Apr 3, 2024

Array API standard conformance tests for dpctl=0.17.0dev0=py310h15de555_168 ran successfully.
Passed: 870
Failed: 8
Skipped: 92

Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @ndgrigorian !

The tests were intended to be skipped on Gen9 hardware, and that is no longer supported by the compiler runtime.

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 88.021%. remained the same
when pulling e697454 on unmute-prod-tests-2024-1
into a0c2aac on master.

@oleksandr-pavlyk
Copy link
Contributor

Please allow 1626 to finish building before merging this PR.

@oleksandr-pavlyk
Copy link
Contributor

Also verified as working on GPU Max.

@ndgrigorian ndgrigorian merged commit d2c1526 into master Apr 4, 2024
@ndgrigorian ndgrigorian deleted the unmute-prod-tests-2024-1 branch April 4, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants