Skip to content

Improve exception raised by broadcast_arrays with no arguments #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

ndgrigorian
Copy link
Collaborator

This PR improves the message of the ValueError raised by broadcast_arrays when called with no arguments.

Closes #1718

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you opening the PR as a draft?

@ndgrigorian ndgrigorian requested a review from antonwolfy June 27, 2024 00:16
Copy link

github-actions bot commented Jun 27, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.18.0dev0=py310h15de555_80 ran successfully.
Passed: 894
Failed: 15
Skipped: 105

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 87.902% (-0.2%) from 88.057%
when pulling 21e1958 on fix-broadcast-arrays-no-args
into 26d34f5 on master.

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @ndgrigorian, LGTM!

@ndgrigorian ndgrigorian merged commit b7fd613 into master Jun 27, 2024
68 of 71 checks passed
@ndgrigorian
Copy link
Collaborator Author

Test failures in linux CI and coverage dip are unrelated to this PR. Test failure appears to be related to the release of 2024.2.0 (as it wasn't present prior).

I will go ahead and merge this and continue to investigate the CI in a separate PR, so that this can move to the dev milestone.

@ndgrigorian ndgrigorian deleted the fix-broadcast-arrays-no-args branch June 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Question about behavior with no array passed to dpt.broadcast_arrays
3 participants