Overloads for array-scalar and scalar-array broadcast element-wise functions #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
ndgrigorian
force-pushed
the
scalar-overloads-for-elementwise-funcs
branch
from
ed69be8 to
c3f411b
Compare
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_384 ran successfully. |
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_374 ran successfully. |
This makes the code easier to understand
Improves readability of in-place code
…dcast scalar and an array Implements these new kernels for addition
ndgrigorian
force-pushed
the
scalar-overloads-for-elementwise-funcs
branch
from
c3f411b to
72809a4
Compare
|
Array API standard conformance tests for dpctl=0.18.0dev0=py310hdf72452_374 ran successfully. |
6 tasks
|
Superseded by #1815 Array-scalar and scalar-array overloads to be investigated further for possibility of performance optimization. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1814
This pull request implements overloads for broadcast arrays and scalars for element-wise functions, and adds kernels for these overloads for addition.
Also refactors how the type maps for in-place operators are implemented to improve code readability.