Skip to content

Backport for gh 1840 #1841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Backport for gh 1840 #1841

merged 3 commits into from
Sep 17, 2024

Conversation

oleksandr-pavlyk
Copy link
Contributor

Backport of changes from gh-1840 to development branch.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

dpctl was still specifying run-time dependency on level-zero though
run_export of level-zero-devel
Copy link

github-actions bot commented Sep 17, 2024

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_50 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@coveralls
Copy link
Collaborator

coveralls commented Sep 17, 2024

Coverage Status

coverage: 87.907%. remained the same
when pulling 8587109 on backport-for-gh-1840
into 45ce08b on master.

ndgrigorian
ndgrigorian previously approved these changes Sep 17, 2024
@oleksandr-pavlyk
Copy link
Contributor Author

test_linux job still shows that "level-zero" is being installed into the test environment. The fix did not work

Copy link

Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_53 ran successfully.
Passed: 894
Failed: 1
Skipped: 119

@oleksandr-pavlyk
Copy link
Contributor Author

Linux test jobs no longer install "level-zero" component in the test environment after the last commit.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 1717b38 into master Sep 17, 2024
49 of 51 checks passed
@oleksandr-pavlyk oleksandr-pavlyk deleted the backport-for-gh-1840 branch September 17, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants