Skip to content

Technical debt #1852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Oct 1, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
47d834e
Add include <new> for std::bad_alloc
oleksandr-pavlyk Sep 28, 2024
e7c11fa
Add missing cgh.use_kernel_bundle(kb) to use kernel from the already …
oleksandr-pavlyk Sep 28, 2024
a313881
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
4963965
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
92dc556
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
6f9712a
Add missing cgh.use_kernel_bundle(kb) to use kernel from the already …
oleksandr-pavlyk Sep 28, 2024
c3511df
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
6ce669d
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
f30c10a
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
748b391
Add include <stdexcept> for std::runtime_error
oleksandr-pavlyk Sep 28, 2024
4e166f3
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 28, 2024
b674d0e
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 28, 2024
1aef76f
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 28, 2024
fc5952d
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 28, 2024
cc3123c
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
3e67818
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
8a72ba6
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
43fab45
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
8d32e1b
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
f440930
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
5433de2
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
158cd6a
Add include <stdexcept> for std::runtime_error, reordered headers
oleksandr-pavlyk Sep 29, 2024
25aff8e
Removed unused qualifier imported into local scope in sort.cpp
oleksandr-pavlyk Sep 30, 2024
854e5c5
Replace #include <exception> with #include <stdexcept>
oleksandr-pavlyk Oct 1, 2024
c04db57
Add missing #include <stdexcept>
oleksandr-pavlyk Oct 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dpctl/apis/include/dpctl4pybind11.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@

#include "dpctl_capi.h"
#include <complex>
#include <exception>
#include <memory>
#include <pybind11/pybind11.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>
Expand Down
1 change: 1 addition & 0 deletions dpctl/tensor/libtensor/include/kernels/accumulators.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <array>
#include <cstdint>
#include <limits>
#include <new>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -173,6 +173,7 @@ as_c_contiguous_array_generic_impl(sycl::queue &exec_q,

sycl::event copy_ev = exec_q.submit([&](sycl::handler &cgh) {
cgh.depends_on(depends);
cgh.use_kernel_bundle(kb);

const sycl::range<1> gRange{n_groups * lws};
const sycl::range<1> lRange{lws};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@
#pragma once
#include <cstddef>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#pragma once
#include <cstddef>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>

#include "kernels/alignment.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <complex>
#include <cstddef>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <type_traits>
#include <utility>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@
#include <complex>
#include <cstddef>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <type_traits>
#include <utility>
Expand Down Expand Up @@ -1349,6 +1350,8 @@ sycl::event _gemm_batch_nm_impl(sycl::queue &exec_q,
sycl::event gemm_ev = exec_q.submit([&](sycl::handler &cgh) {
cgh.depends_on(depends);

cgh.use_kernel_bundle(kb);

using LocAccT1 = sycl::local_accessor<resTy, 1>;
LocAccT1 local_A_block(wg_delta_n * wi_delta_n * wi_delta_k, cgh);

Expand Down
1 change: 1 addition & 0 deletions dpctl/tensor/libtensor/include/kernels/reductions.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
#include <complex>
#include <cstddef>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <type_traits>
#include <utility>
Expand Down
2 changes: 2 additions & 0 deletions dpctl/tensor/libtensor/include/utils/output_validation.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@
//===----------------------------------------------------------------------===//

#pragma once
#include <stdexcept>

#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>

Expand Down
1 change: 1 addition & 0 deletions dpctl/tensor/libtensor/include/utils/type_dispatch.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
//===----------------------------------------------------------------------===//

#pragma once
#include <stdexcept>

#include "dpctl4pybind11.hpp"
#include "type_dispatch_building.hpp"
Expand Down
2 changes: 1 addition & 1 deletion dpctl/tensor/libtensor/include/utils/type_utils.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

#pragma once
#include <complex>
#include <exception>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>

Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/accumulators.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,17 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===----------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <cstdint>
#include <limits>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "kernels/accumulators.hpp"
#include "simplify_iteration_space.hpp"
#include "utils/memory_overlap.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,16 +24,18 @@

#pragma once

#include "dpctl4pybind11.hpp"
#include <cstdint>
#include <limits>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "kernels/accumulators.hpp"
#include "simplify_iteration_space.hpp"
#include "utils/memory_overlap.hpp"
Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/boolean_advanced_indexing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,17 @@
/// dpctl.tensor.extract, dpctl.tensor.nonzero
//===----------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <cstdint>
#include <limits>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "boolean_advanced_indexing.hpp"
#include "kernels/boolean_advanced_indexing.hpp"
#include "simplify_iteration_space.hpp"
Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/clip.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,16 @@
/// dpctl.tensor.clip
//===----------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <complex>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>

#include "dpctl4pybind11.hpp"
#include <pybind11/complex.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <sycl/sycl.hpp>
#include <utility>

#include "clip.hpp"
#include "kernels/clip.hpp"
Expand Down
9 changes: 5 additions & 4 deletions dpctl/tensor/libtensor/source/copy_and_cast_usm_to_usm.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,16 +25,17 @@
#include <algorithm>
#include <complex>
#include <cstdint>
#include <pybind11/complex.h>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <thread>
#include <type_traits>
#include <utility>

#include "dpctl4pybind11.hpp"
#include <pybind11/complex.h>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "kernels/copy_and_cast.hpp"
#include "utils/memory_overlap.hpp"
Expand Down
6 changes: 4 additions & 2 deletions dpctl/tensor/libtensor/source/copy_for_reshape.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,20 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===----------------------------------------------------------------------===//

#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "copy_for_reshape.hpp"
#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>

#include "copy_for_reshape.hpp"
#include "kernels/copy_and_cast.hpp"
#include "utils/offset_utils.hpp"
#include "utils/output_validation.hpp"
#include "utils/sycl_alloc_utils.hpp"
#include "utils/type_dispatch.hpp"
#include <pybind11/pybind11.h>

namespace dpctl
{
Expand Down
6 changes: 4 additions & 2 deletions dpctl/tensor/libtensor/source/copy_for_roll.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,18 +22,20 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===----------------------------------------------------------------------===//

#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "copy_for_roll.hpp"
#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>

#include "copy_for_roll.hpp"
#include "kernels/copy_and_cast.hpp"
#include "utils/offset_utils.hpp"
#include "utils/output_validation.hpp"
#include "utils/sycl_alloc_utils.hpp"
#include "utils/type_dispatch.hpp"
#include <pybind11/pybind11.h>

#include "simplify_iteration_space.hpp"

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,15 @@
//===----------------------------------------------------------------------===//
#pragma once

#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "elementwise_functions_type_utils.hpp"
#include "kernels/alignment.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,18 @@
/// specifically functions for elementwise operations.
//===----------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <complex>
#include <cstdint>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "elementwise_functions.hpp"
#include "simplify_iteration_space.hpp"
#include "true_divide.hpp"
Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/full_ctor.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,14 +22,16 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===--------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <complex>
#include <pybind11/complex.h>
#include <pybind11/pybind11.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/complex.h>
#include <pybind11/pybind11.h>

#include "kernels/constructors.hpp"
#include "utils/output_validation.hpp"
#include "utils/type_dispatch.hpp"
Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/integer_advanced_indexing.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -26,13 +26,15 @@
#include <algorithm>
#include <complex>
#include <cstdint>
#include <pybind11/complex.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>

#include "dpctl4pybind11.hpp"
#include <pybind11/complex.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "kernels/integer_advanced_indexing.hpp"
#include "utils/memory_overlap.hpp"
#include "utils/offset_utils.hpp"
Expand Down
10 changes: 6 additions & 4 deletions dpctl/tensor/libtensor/source/linalg_functions/dot.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,17 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===--------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <cstdint>
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/numpy.h>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "dot.hpp"
#include "dot_atomic_support.hpp"
#include "dot_dispatch.hpp"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@

#include <algorithm>
#include <cstdint>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <type_traits>
#include <utility>
Expand Down
8 changes: 5 additions & 3 deletions dpctl/tensor/libtensor/source/repeat.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,17 @@
/// This file defines functions of dpctl.tensor._tensor_impl extensions
//===--------------------------------------------------------------------===//

#include "dpctl4pybind11.hpp"
#include <cstdint>
#include <limits>
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>
#include <stdexcept>
#include <sycl/sycl.hpp>
#include <utility>
#include <vector>

#include "dpctl4pybind11.hpp"
#include <pybind11/pybind11.h>
#include <pybind11/stl.h>

#include "kernels/repeat.hpp"
#include "simplify_iteration_space.hpp"
#include "utils/memory_overlap.hpp"
Expand Down
Loading
Loading