-
Notifications
You must be signed in to change notification settings - Fork 30
Bugfix/gh 1874 result type #1877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
If dtypes list is empty, populate it with first Python scalar from weak_dtypes list.
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_148 ran successfully. |
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_151 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, and array API is considering specifying that only scalar types are acceptable in result_type
, so this is a subtle change toward supporting the next version of the spec.
Array API standard conformance tests for dpctl=0.19.0dev0=py310hdf72452_152 ran successfully. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @oleksandr-pavlyk for fixing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Windows tests now passing, LGTM!
Closes gh-1874
If inputs consist solely of weak dtypes, pre-prepopulate
dtypes
lists with scalar behind the firstweak_dtypes
element.Add tests that
dpt.result_types(sc1, sc2)
gives the same result regardless whether the scalar is a Python scalar (weak dtype), or corresponding NumPy scalar (strong dtype).