Skip to content

Change "max dimensions" to None in array API capabilities #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 5, 2025

Conversation

ndgrigorian
Copy link
Collaborator

tensor.usm_ndarray can support potentially arbitrary dimensions

Changes will need to be made where NumPy arrays are created from usm_ndarray (printing, dlpack with kDLCPU, asnumpy/from_numpy)

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?
  • If this PR is a work in progress, are you opening the PR as a draft?

`usm_ndarray` can support potentially arbitrary dimensions
Copy link

github-actions bot commented May 1, 2025

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@coveralls
Copy link
Collaborator

Coverage Status

coverage: 86.363%. remained the same
when pulling a6500fa on unrestrict-max-dimensions
into 32948cd on master.

Copy link

github-actions bot commented May 1, 2025

Array API standard conformance tests for dpctl=0.20.0dev0=py310h93fe807_179 ran successfully.
Passed: 1109
Failed: 3
Skipped: 119

Copy link
Collaborator

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @ndgrigorian
Do we need to note the change in CHANGELOG.md? Or it will be done before the release directly?

@ndgrigorian
Copy link
Collaborator Author

LGTM! Thank you @ndgrigorian Do we need to note the change in CHANGELOG.md? Or it will be done before the release directly?

It will be done before the release.

Adding to changelog as a task was added to simplify the process at release, but it was found that it didn't really help avoid a number of ugly merge conflicts, etc.

Really the chore should be removed and we should switch to towncrier.

@ndgrigorian ndgrigorian merged commit 5f5600e into master May 5, 2025
75 of 77 checks passed
@ndgrigorian ndgrigorian deleted the unrestrict-max-dimensions branch May 5, 2025 16:54
antonwolfy added a commit to IntelPython/dpnp that referenced this pull request May 6, 2025
[dpctl-2071](IntelPython/dpctl#2071) is going to
change `"max dimensions"` to `None` in array API capabilities.
This PR updates a test to align with that change.
github-actions bot added a commit to IntelPython/dpnp that referenced this pull request May 6, 2025
[dpctl-2071](IntelPython/dpctl#2071) is going to
change `"max dimensions"` to `None` in array API capabilities.
This PR updates a test to align with that change. 2b30bab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants