Skip to content

scripts/build_locally.py now supports --cmake-opts option #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Added support for --cmake-opts option inspired by LLVM configure script. This can be used to experiment with adding of additional options to cmake. For example, to try gold linker I used

python scripts/build_locally.py --cmake-opts="-DCMAKE_EXE_LINKER_FLAGS=-use-gold-plugin -DCMAKE_CXX_FLAGS=-flto"
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

Added support for --cmake-opts option inspired by LLVM configure
script. This can be used to experiment with adding of additional
options to cmake. For example, to try gold linker I used

```
python scripts/build_locally.py --cmake-opts="-DCMAKE_EXE_LINKER_FLAGS=-use-gold-plugin -DCMAKE_CXX_FLAGS=-flto"
```
@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests failed to run for dpctl=0.14.0dev0=py310h8c27c75_124.

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.051% when pulling e6e608a on script-build-locally-support-cmake-opts into ecec512 on master.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 880b0c3 into master Sep 29, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the script-build-locally-support-cmake-opts branch September 29, 2022 21:34
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants