Skip to content

[cleanup/tensor, part 4] Made contract_iter and contract_iter2 functions templated to avoid needing to include pybind11 headers #933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 16, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

Code for contract_iter and contract_iter2 functions in "strided_iters.hpp" used identifiers from ::pybind11 namespace.

Made these functions templated passing necessary types via template parameters.

This is avoid using py::value_error and py::ssize_t and py::type_error in there explicitly.

Use in "tensor_py.cpp" has been adjusted.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

This is avoid using py::value_error and py::ssize_t and py::type_error
in there explicitly.

Use in tensor_py.cpp adjusted
@oleksandr-pavlyk oleksandr-pavlyk changed the title Made contract_iter and contract_iter2 templated [cleanup/tensor, part 4] Made contract_iter and contract_iter2 functions templated to avoid needing to include pybind11 headers Oct 15, 2022
@github-actions
Copy link

@github-actions
Copy link

Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_180 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk
Copy link
Contributor Author

I think this is pretty straightforward commit, so I am going to merge it.

@oleksandr-pavlyk oleksandr-pavlyk merged commit 67802a3 into cleanup/tensor Oct 16, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the cleanup-tensor-step4 branch October 16, 2022 16:55
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@oleksandr-pavlyk oleksandr-pavlyk mentioned this pull request Oct 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant