Edits to documentation per review feedback #936
Conversation
|
View rendered docs @ https://intelpython.github.io/dpctl/pulls/936/index.html |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_169 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_170 ran successfully. |
There was a problem hiding this comment.
@oleksandr-pavlyk Since the doc is being touched, can you add a short few lines to address #937. I will be good to have @alexandraepan review them in this PR itself.
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_196 ran successfully. |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_225 ran successfully. |
oleksandr-pavlyk
force-pushed
the
docs-review-edits
branch
2 times, most recently
from
9b673b8 to
15206e3
Compare
Made intended use of event to ensure completion of submitted operation from host side of the application explicit. Removed note that lsplatform is new in dpctl 0.7 Update docs/docfiles/user_guides/QuickStart.rst Streamlined notice about GPU drivers per PR review feedback. Co-authored-by: Alexandra <[email protected]>
oleksandr-pavlyk
force-pushed
the
docs-review-edits
branch
from
15206e3 to
029bc53
Compare
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_223 ran successfully. |
1 similar comment
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_223 ran successfully. |
docs/docfiles/intro.rst
Outdated
| Dpctl implements N-dimensional array Python object :class:`dpctl.tensor.usm_ndarray` to | ||
| logically address USM memory allocations, and contains growing implementation of | ||
| operations on such objects confofrming :array_api:`array API specification <>` in | ||
| :class:`dpctl.tensor` namespace. | ||
|
|
||
| Dpctl also supports the DPCPP :oneapi_filter_selection:`oneapi::filter_selector <>` extension and has |
There was a problem hiding this comment.
Let us change to DPC++ here too.
docs/docfiles/intro.rst
Outdated
| using SYCL USM memory. It makes it possible to create Python objects that are | ||
| backed by SYCL USM memory. | ||
|
|
||
| Dpctl implements N-dimensional array Python object :class:`dpctl.tensor.usm_ndarray` to |
There was a problem hiding this comment.
How about:
"Dpctl also includes a reference implementation for :array_api:array API specification <> using DPC++ and USM memory allocation under the :class:dpctl.tensor sub-module. The :class:dpctl.tensor sub-module provides an N-dimensional array Python object :class:dpctl.tensor.usm_ndarray and a growing implementation of :array_api:array API specification <> complaint operations on instances of the array class. "
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_226 ran successfully. |
|
Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞 |
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_226 ran successfully. |
Made explicit the intended use of event to ensure completion of submitted operation from host side of the application.
Removed note that
dpctl.lsplatform()is new in dpctl 0.7Closes #937
Closes #938
@alexandraepan