Infodev doc review #944
Merged
Infodev doc review #944
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
diptorupd
reviewed
Oct 19, 2022
Co-authored-by: Oleksandr Pavlyk <[email protected]>
Co-authored-by: Diptorup Deb <[email protected]>
…/dpctl into infodev-doc-review
|
@oleksandr-pavlyk @diptorupd I believe, we can drop asterisks after programming languages. |
diptorupd
previously approved these changes
Oct 26, 2022
oleksandr-pavlyk
previously approved these changes
Oct 26, 2022
oleksandr-pavlyk
dismissed stale reviews from diptorupd and themself
via
3af9993
|
Thank you @alexandraepan, I ran |
oleksandr-pavlyk
approved these changes
Oct 26, 2022
There was a problem hiding this comment.
LGTM! Thank you @alexandraepan
I noticed C++ compilation warnings while compiling DPCTLSyclInterface sources.
I opened #952 with the fix.
|
Array API standard conformance tests for dpctl=0.14.0dev0=py310h8c27c75_220 ran successfully. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix errors and mistakes in the documentation.
@oleksandr-pavlyk