Skip to content

Fixed compilation error on triul_ctor on Windows with Python 3.10 #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

oleksandr-pavlyk
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk commented Nov 8, 2022

Use full qualifier in template parameter to fix build break on Windows with CPython 3.10

  • Have you provided a meaningful PR description?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

@coveralls
Copy link
Collaborator

Coverage Status

Coverage remained the same at 82.032% when pulling f0e6afc on use-full-type-qualifier-in-triul_ctor into 70ec4d7 on master.

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_49 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

@oleksandr-pavlyk oleksandr-pavlyk merged commit 3d04af8 into master Nov 8, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the use-full-type-qualifier-in-triul_ctor branch November 8, 2022 18:11
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

Array API standard conformance tests for dpctl=0.14.0dev1=py310h8c27c75_55 ran successfully.
Passed: 33
Failed: 801
Skipped: 3138

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants