Skip to content

Commit 1aca076

Browse files
authored
Fix abs (#136)
* add change absolute * delete not needed str
1 parent bfd8e84 commit 1aca076

File tree

3 files changed

+10
-20
lines changed

3 files changed

+10
-20
lines changed

dpnp/backend/backend_iface.hpp

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -118,16 +118,14 @@ INP_DLLEXPORT void
118118
*
119119
* @param [in] array1_in Input array.
120120
*
121-
* @param [in] input_shape Input shape.
122-
*
123121
* @param [out] result1 Output array.
124122
*
125123
* @param [in] size Number of elements in input arrays.
126124
*
127125
*/
128126
template <typename _DataType>
129127
INP_DLLEXPORT void
130-
custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
128+
custom_elemwise_absolute_c(void* array1_in, void* result1, size_t size);
131129

132130
/**
133131
* @ingroup BACKEND_API

dpnp/backend/custom_kernels_mathematical.cpp

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -35,7 +35,7 @@ template <typename _KernelNameSpecialization>
3535
class custom_elemwise_absolute_c_kernel;
3636

3737
template <typename _DataType>
38-
void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size)
38+
void custom_elemwise_absolute_c(void* array1_in, void* result1, size_t size)
3939
{
4040
if (!size)
4141
{
@@ -46,10 +46,6 @@ void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_
4646
_DataType* array1 = reinterpret_cast<_DataType*>(array1_in);
4747
_DataType* result = reinterpret_cast<_DataType*>(result1);
4848

49-
const size_t input_shape_size = input_shape.size();
50-
size_t* input_offset_shape = reinterpret_cast<size_t*>(dpnp_memory_alloc_c(input_shape_size * sizeof(long)));
51-
size_t* result_offset_shape = reinterpret_cast<size_t*>(dpnp_memory_alloc_c(input_shape_size * sizeof(long)));
52-
5349
if constexpr (std::is_same<_DataType, double>::value || std::is_same<_DataType, float>::value)
5450
{
5551
// https://docs.oneapi.com/versions/latest/onemkl/abs.html
@@ -79,20 +75,17 @@ void custom_elemwise_absolute_c(void* array1_in, const std::vector<long>& input_
7975
}
8076

8177
event.wait();
82-
83-
free(input_offset_shape, DPNP_QUEUE);
84-
free(result_offset_shape, DPNP_QUEUE);
8578
}
8679

8780
template void custom_elemwise_absolute_c<double>(void* array1_in,
88-
const std::vector<long>& input_shape,
8981
void* result1,
9082
size_t size);
9183
template void custom_elemwise_absolute_c<float>(void* array1_in,
92-
const std::vector<long>& input_shape,
9384
void* result1,
9485
size_t size);
95-
template void
96-
custom_elemwise_absolute_c<long>(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
97-
template void
98-
custom_elemwise_absolute_c<int>(void* array1_in, const std::vector<long>& input_shape, void* result1, size_t size);
86+
template void custom_elemwise_absolute_c<long>(void* array1_in,
87+
void* result1,
88+
size_t size);
89+
template void custom_elemwise_absolute_c<int>(void* array1_in,
90+
void* result1,
91+
size_t size);

dpnp/backend_mathematical.pyx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,7 @@ __all__ += [
6363
]
6464

6565

66-
ctypedef void(*fptr_custom_elemwise_absolute_1in_1out_t)(void * , dparray_shape_type & ,
67-
void * , size_t)
66+
ctypedef void(*fptr_custom_elemwise_absolute_1in_1out_t)(void * , void * , size_t)
6867

6968

7069
cpdef dparray dpnp_absolute(dparray input):
@@ -83,7 +82,7 @@ cpdef dparray dpnp_absolute(dparray input):
8382

8483
cdef fptr_custom_elemwise_absolute_1in_1out_t func = <fptr_custom_elemwise_absolute_1in_1out_t > kernel_data.ptr
8584
# call FPTR function
86-
func(input.get_data(), input_shape, result.get_data(), input.size)
85+
func(input.get_data(), result.get_data(), input.size)
8786

8887
return result
8988

0 commit comments

Comments
 (0)