Skip to content

Fix abs #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 14, 2020
Merged

Fix abs #136

merged 3 commits into from
Oct 14, 2020

Conversation

Rubtsowa
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 12, 2020

Codecov Report

Merging #136 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #136   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          19      19           
  Lines        1242    1242           
  Branches      330     330           
======================================
  Misses       1242    1242           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b26d624...ee4bbf0. Read the comment docs.

@Alexander-Makaryev
Copy link
Contributor

Alexander-Makaryev commented Oct 12, 2020

@Rubtsowa
Could you please look into #127?
Pay attention to these changes because they cover the same part of code.

@shssf
Copy link
Contributor

shssf commented Oct 12, 2020

is this PR ready for merge?

@Alexander-Makaryev
Copy link
Contributor

@Rubtsowa
cdef size_t input_shape_size = input.ndim
https://github.com/IntelPython/dpnp/blob/master/dpnp/backend_mathematical.pyx#L72
Is still not used anywhere.
Could you please check one more time my comments in your original PR?
#104

@shssf shssf merged commit 1aca076 into IntelPython:master Oct 14, 2020
@Rubtsowa Rubtsowa deleted the fix_abs branch October 20, 2020 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants