Add random_state class #1139
Merged
Add random_state class #1139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukichevaPolina
requested review from
Alexander-Makaryev,
densmirn and
KsanaKozlova
densmirn
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Looks like we need to support the following use case:
rs = dpnp.random.RandomState(seed=1, sycl_queue=dpctl.SyclQueue())
rs.uniform(lower=0., upper=1, size=10, usm_type='device')Perhaps we also need to provide parameter device for RandomState.
@Alexander-Makaryev what do you think about extra parameter?
densmirn
approved these changes
Mar 9, 2022
dpnp/random/dpnp_iface_random.py
Outdated
|
|
||
|
|
||
| seed = 1 | ||
| default_random_state = RandomState(seed) |
There was a problem hiding this comment.
I would rename it to dpnp_random_state if patched the PR.
|
Building in CI is failed. |
… MKL relating things into source file)
…ndom.seed() calls
antonwolfy
requested review from
oleksandr-pavlyk
and removed request for
Alexander-Makaryev and
KsanaKozlova
antonwolfy
force-pushed
the
random_cfd
branch
4 times, most recently
from
252fd94 to
f7bc0b3
Compare
antonwolfy
force-pushed
the
random_cfd
branch
2 times, most recently
from
77d1c87 to
84d224d
Compare
antonwolfy
force-pushed
the
random_cfd
branch
from
84d224d to
a697ab7
Compare
oleksandr-pavlyk
approved these changes
Nov 8, 2022
There was a problem hiding this comment.
I think this is big improvement over previous state.
Existing minor issues will be addressed in subsequent RPs.
Thanks @antonwolfy for finishing this work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.