Skip to content

remove mixed host\dev impl from dpnp_all dpnp_any #1155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vladislav-markin
Copy link

@vladislav-markin vladislav-markin commented Apr 4, 2022

Remove mixed host\dev implementation for 3 functions: dpnp_all_c(), dpnp_allclose_c() and dpnp_any_c().
Keep away from excess memcpy() calls between host and device memory for "result" pointer.
The "result" pointer has to be set with an initial value in kernel code rather on host one.
Add missing DPCTLEvent_Delete() invocations for absolute versions of function calls without SYCL arguments and return type.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy requested review from oleksandr-pavlyk and removed request for densmirn and Alexander-Makaryev August 17, 2022 17:46
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if dpnp_all_c has a static_assert to check that _ResultType is bool.

@oleksandr-pavlyk
Copy link
Contributor

So I assume this PR has been superseded by gh-1301 and gh-1302. Please close if so.

@antonwolfy antonwolfy closed this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants