MEAN add MKL kernel #119
Merged
MEAN add MKL kernel #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #119 +/- ##
=======================================
Coverage 51.45% 51.45%
=======================================
Files 19 19
Lines 1240 1240
Branches 329 329
=======================================
Hits 638 638
Misses 340 340
Partials 262 262 Continue to review full report at Codecov.
|
shssf
reviewed
Oct 6, 2020
|
|
||
| custom_sum_c<_DataType>(array1_in, sum, size); | ||
| cl::sycl::event event = mkl_stats::mean(DPNP_QUEUE, dataset, result); |
There was a problem hiding this comment.
Could you please add a comment with documentation pointer to this functionality from MKL?
There was a problem hiding this comment.
something like
// http://asdada
shssf
reviewed
Oct 6, 2020
| result[0] = static_cast<_ResultType>(sum[0]) / static_cast<_ResultType>(size); | ||
|
|
||
| dpnp_memory_free_c(sum); | ||
| } | ||
|
|
||
| #if 0 |
There was a problem hiding this comment.
Also, please delete this debug code
shssf
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.