Use full() function from dpctl.tensor #1218
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
reviewed
Nov 2, 2022
There was a problem hiding this comment.
Also it would be great to extend test_array_creation() test in tests/test_sycl_queue.py and to add new test_full() in tests/test_arraycreation.py covering basic functionality and corner cases.
The following tests needs to be excluded from ignore list, i.e. to be removed from tests/skipped_tests_gpu.tbl file:
tests/third_party/cupy/creation_tests/test_basic.py::TestBasic::test_full
tests/third_party/cupy/creation_tests/test_basic.py::TestBasic::test_full_default_dtype
tests/third_party/cupy/creation_tests/test_basic.py::TestBasic::test_full_default_dtype_cpu_input
antonwolfy
reviewed
Dec 1, 2022
antonwolfy
approved these changes
Dec 7, 2022
dpnp/dpnp_container.py
Outdated
| if isinstance(fill_value, dpnp_array): | ||
| fill_value = fill_value.get_array() | ||
|
|
||
| """Creates `dpnp_array` where every element is equal to fill_value.""" |
There was a problem hiding this comment.
This docstring is blatantly wrong when fill_value is an array. NumPy says "Return a new array of given shape and type, filled with fill_value."
oleksandr-pavlyk
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use full() function from dpctl.tensor module instead of DPNP backend implementation.
A cython code relating to full() call is cleaned up.