Skip to content

SUM add MKL kernel #122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 10, 2020
Merged

SUM add MKL kernel #122

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e071135
SUM add MKL kernel
densmirn Oct 7, 2020
71b5435
SUM fix link to MKL documentation
densmirn Oct 7, 2020
6e416c1
Merge branch 'master' of https://github.com/IntelPython/dpnp into fea…
densmirn Oct 7, 2020
e985c85
SUM remove excess include
densmirn Oct 7, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 23 additions & 17 deletions dpnp/backend/custom_kernels_reduction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@
#include <backend_iface.hpp>
#include "queue_sycl.hpp"

namespace mkl_stats = oneapi::mkl::stats;

template <typename _KernelNameSpecialization>
class custom_sum_c_kernel;

Expand All @@ -44,28 +46,32 @@ void custom_sum_c(void* array1_in, void* result1, size_t size)
_DataType* result = reinterpret_cast<_DataType*>(result1);

#if 1 // naive algorithm
// cl::sycl::range<1> gws(size);
auto policy = oneapi::dpl::execution::make_device_policy<custom_sum_c_kernel<_DataType>>(DPNP_QUEUE);
if constexpr (std::is_same<_DataType, double>::value || std::is_same<_DataType, float>::value)
{
// https://docs.oneapi.com/versions/latest/onemkl/mkl-stats-make_dataset.html
auto dataset = mkl_stats::make_dataset<mkl_stats::layout::row_major>(1, size, array_1);

// sycl::buffer<_DataType, 1> array_1_buf(array_1, gws);
// auto it_begin = oneapi::dpl::begin(array_1_buf);
// auto it_end = oneapi::dpl::end(array_1_buf);
// https://docs.oneapi.com/versions/latest/onemkl/mkl-stats-raw_sum.html
cl::sycl::event event = mkl_stats::raw_sum(DPNP_QUEUE, dataset, result);

_DataType accumulator = 0;
accumulator = std::reduce(policy, array_1, array_1 + size, _DataType(0), std::plus<_DataType>());
event.wait();
}
else
{
// cl::sycl::range<1> gws(size);
auto policy = oneapi::dpl::execution::make_device_policy<custom_sum_c_kernel<_DataType>>(DPNP_QUEUE);

policy.queue().wait();
// sycl::buffer<_DataType, 1> array_1_buf(array_1, gws);
// auto it_begin = oneapi::dpl::begin(array_1_buf);
// auto it_end = oneapi::dpl::end(array_1_buf);

#if 0 // verification
accumulator = 0;
for (size_t i = 0; i < size; ++i)
{
accumulator += array_1[i];
}
// std::cout << "result: " << accumulator << std::endl;
#endif
_DataType accumulator = 0;
accumulator = std::reduce(policy, array_1, array_1 + size, _DataType(0), std::plus<_DataType>());

result[0] = accumulator;
policy.queue().wait();

result[0] = accumulator;
}

return;

Expand Down