Skip to content

Use icpx instead of dpcpp on Linux #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 28, 2022

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 9, 2022

Since SYCL DPC++ 2023 compiler use of dpcpp is deprecated and will be removed in a future release.
The PR replaces dpcpp with use of 'icpx -fsycl' in case of building for Linux OS.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 9, 2022
@antonwolfy antonwolfy force-pushed the dpcpp_is_deprecated branch 5 times, most recently from 67c9f89 to 470faf7 Compare November 10, 2022 13:08
@antonwolfy antonwolfy changed the title Use icpx instead of dpcpp due to deprecation Use icpx instead of dpcpp on Linux Nov 28, 2022
@oleksandr-pavlyk
Copy link
Contributor

Hopefully one day dpnp gets to transition to using CMake, in which case both Windows and Linux would be addressed by a single change in CMakeLists.txt.

Look good for now!

@antonwolfy antonwolfy merged commit 5a710bb into IntelPython:master Nov 28, 2022
@antonwolfy antonwolfy deleted the dpcpp_is_deprecated branch November 28, 2022 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants