Skip to content

Add support of combining arrays with different USM types #1237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 21, 2022
Merged

Add support of combining arrays with different USM types #1237

merged 1 commit into from
Nov 21, 2022

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 17, 2022 •
edited
Loading

The PR implements a support of combining arrays with different USM types.
The change is mainly about to replace temporary dpnp call get_usm_type() with dpctl API call dpctl.utils.get_coerced_usm_type(), since it is available now.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 17, 2022
@antonwolfy antonwolfy merged commit 6171a71 into IntelPython:master Nov 21, 2022
@antonwolfy antonwolfy deleted the coerced_usm_types branch November 21, 2022 14:28
oleksandr-pavlyk
oleksandr-pavlyk reviewed Nov 21, 2022
View reviewed changes
Copy link
Contributor

@oleksandr-pavlyk oleksandr-pavlyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @antonwolfy

@antonwolfy antonwolfy mentioned this pull request Nov 21, 2022
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oleksandr-pavlyk oleksandr-pavlyk oleksandr-pavlyk left review comments

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @oleksandr-pavlyk