Skip to content

Use main channel instead of defaults #1241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Nov 21, 2022

It's proper to explicitly define main channel when installing packages from conda rather than to rely on a value of defaults channel in conda configuration.
This is because main channel is what exactly required for building and testing dpnp and also because conda is configured by conda-incubator/setup-miniconda github action and we have no control on that (can't guarantee defaults channel is the same as main one).

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Nov 21, 2022
@antonwolfy antonwolfy merged commit c4809ee into IntelPython:master Nov 22, 2022
@antonwolfy antonwolfy deleted the replace_default_with_main branch November 22, 2022 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants