ELEMWISE 1arg_2types add MKL kernels #130
Conversation
Codecov Report
@@ Coverage Diff @@
## master #130 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 19 19
Lines 1242 1242
Branches 330 330
======================================
Misses 1242 1242 Continue to review full report at Codecov.
|
| MACRO_CUSTOM_1ARG_2TYPES_MKL_OP(tanh, cl::sycl::tanh, oneapi::mkl::vm::tanh) | ||
| MACRO_CUSTOM_1ARG_2TYPES_MKL_OP(trunc, cl::sycl::trunc, oneapi::mkl::vm::trunc) | ||
|
|
||
| #undef MACRO_CUSTOM_1ARG_2TYPES_MKL_OP |
There was a problem hiding this comment.
Please keep all these things in the same file (do not rename file)
| @@ -46,7 +46,7 @@ | |||
| size_t i = global_id[0]; /*for (size_t i = 0; i < size; ++i)*/ \ | |||
| { \ | |||
| _DataType_output input_elem = array1[i]; \ | |||
| result[i] = __operation__; \ | |||
| result[i] = __operation__(input_elem); \ | |||
There was a problem hiding this comment.
please keep input_elem as before. I would propose to keep this flexibility for this moment.
| @@ -67,6 +67,50 @@ | |||
|
|
|||
| #include <custom_1arg_2type_tbl.hpp> | |||
|
|
|||
| #define MACRO_CUSTOM_1ARG_2TYPES_MKL_OP(__name__, __operation__, __mkl_operation__) \ | |||
There was a problem hiding this comment.
- Could you please add documentation for this macro (if is not exists).
- please do not use "MKL" in names
dpnp/backend/backend_iface.hpp
Outdated
| @@ -400,6 +400,10 @@ INP_DLLEXPORT void custom_var_c( | |||
| template <typename _DataType_input, typename _DataType_output> \ | |||
| INP_DLLEXPORT void custom_elemwise_##__name__##_c(void* array1, void* result1, size_t size); | |||
|
|
|||
| #define MACRO_CUSTOM_1ARG_2TYPES_2OPS(__name__, __operation1__, __operation2__) \ | |||
There was a problem hiding this comment.
Why we need extra macro? It is the same as existed MACRO_CUSTOM_1ARG_2TYPES_OP
There was a problem hiding this comment.
@shssf I didn't find a way how to combine 2 macros with 2 and 3 parameters to a single one with 3 input parameters. Please let me know If you know how to do that.
I tried to use nullptr for the third parameter of the macro __operation2__, but it didn't work.
densmirn
force-pushed
the
feature/1arg_2types
branch
from
d7e08bb to
cf91f09
Compare
|
I hope I resolved sources conflict correctly. |
Looks like yes. |
Not all the operations supported by MKL, so separated table of the operations on 2 ones (supported and unsupported by MKL).
cl::sycl::fabsis equal tooneapi::mkl::vm::abscl::sycl::logis equal tooneapi::mkl::vm::ln