tests: more tests for random funcs #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
======================================
Coverage 0.00% 0.00%
======================================
Files 19 19
Lines 1240 1262 +22
Branches 329 335 +6
======================================
- Misses 1240 1261 +21
- Partials 0 1 +1
Continue to review full report at Codecov.
|
samir-nasibli
force-pushed
the
samir-nasibli/test/random_module
branch
from
c1f8f08 to
cfc78db
Compare
* added test_randn_normal_distribution * added test_radnom_seed * skipped tests * scipy import under the coment currently : TODO
samir-nasibli
force-pushed
the
samir-nasibli/test/random_module
branch
from
cfc78db to
2c31c2b
Compare
shssf
reviewed
Oct 12, 2020
| alpha = 0.05 | ||
| dpnp.random.seed(28041990) | ||
| x = dpnp.random.randn(pts) | ||
| _, p = stats.normaltest(x) |
There was a problem hiding this comment.
How it is works is stats commented out above?
shssf
reviewed
Oct 12, 2020
tests/test_random.py
Outdated
| a1 = func(args) | ||
| dpnp.random.seed(seed) | ||
| a2 = func(args) | ||
| assert_array_equal(a1, a2) |
There was a problem hiding this comment.
I'm not sure this function is suitable to compare floating point arrays. I think assert_allclose function should be used
Example:
Line 59 in b26d624
There was a problem hiding this comment.
rtol=1e-05 is suitable for float datatype. For double it should be much stronger.
shssf
approved these changes
Oct 12, 2020
* added comments for test_randn_normal_distribution * using assert_allclose in test_radnom_seed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_randn_normal_distribution. See: https://docs.scipy.org/doc/scipy/reference/generated/scipy.stats.normaltest.htmltest_radnom_seedTODO:
scipydependency into test build