Skip to content

Add a copy for strided arrays in dpnp.dot() #1424

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 13, 2023
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jun 12, 2023

The PR proposes to add an additional step with creating a contiguous copy of input array if it wasn't placed in contiguous memory. This has to provide better performance for the use case, since OneMKL function dot will be used.
Additionally, the PR is assumed to be introduced together with #1389, where excess copy is removed during transposing of an array.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Jun 12, 2023
@antonwolfy antonwolfy merged commit 5cdc287 into master Jun 13, 2023
@antonwolfy antonwolfy deleted the dot_copy_with_strides branch June 13, 2023 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants