Skip to content

Move search for compiler and omp from setup.py #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2020
Merged

Move search for compiler and omp from setup.py #146

merged 3 commits into from
Oct 16, 2020

Conversation

densmirn
Copy link
Contributor

No description provided.

@densmirn densmirn requested a review from shssf October 15, 2020 12:30
@codecov
Copy link

codecov bot commented Oct 15, 2020 •
edited
Loading

Codecov Report

Merging #146 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #146   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files          19      19           
  Lines        1242    1242           
  Branches      330     330           
======================================
  Misses       1242    1242

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1300e61...b512a44. Read the comment docs.

shssf
shssf reviewed Oct 15, 2020
View reviewed changes
setup.py Outdated
@@ -49,7 +49,7 @@
from utils.command_style import source_style
from utils.command_clean import source_clean
from utils.command_build_clib import custom_build_clib
from utils.dpnp_build_utils import find_mathlib
from utils.dpnp_build_utils import find_cmplr, find_mathlib, find_omp, IS_LIN, IS_WIN
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

moving IS_LIN or IS_WIN logic to utils is completely wrong. In utils we have to have simple procedure to find library (headers) by paths. Nothing else.

@shssf shssf added the in progress Please do not merge. Work is in progress. label Oct 15, 2020
@densmirn densmirn removed the in progress Please do not merge. Work is in progress. label Oct 16, 2020
@shssf shssf merged commit 6d2aaaf into master Oct 16, 2020
@shssf shssf deleted the feature/find_cmplr branch October 16, 2020 18:43
antonwolfy added a commit that referenced this pull request Apr 4, 2025
@antonwolfy
Pin libxml2 version to 2.13.7 (#2409)
073a86c 
This PR pins `libxml2` version to `2.13.7` due to libs dependency issue
with `2.14.0` version as reported on
[#146](conda-forge/libxml2-feedstock#146).

Without that change the conda package can not be build through GitHub
action, since `conda-build` raises error:
```python
Traceback (most recent call last):
  File "C:\Users\runneradmin\miniconda3\envs\build\Scripts\conda-build-script.py", line 6, in <module>
    from conda_build.cli.main_build import execute
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\cli\main_build.py", line 19, in <module>
    from .. import api, build, source, utils
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\api.py", line [24](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:25), in <module>
    from .config import DEFAULT_PREFIX_LENGTH as _prefix_length
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\config.py", line 28, in <module>
    from .utils import (
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\utils.py", line 51, in <module>
    import libarchive
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\__init__.py", line 1, in <module>
    from .entry import ArchiveEntry
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\entry.py", line 6, in <module>
    from . import ffi
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\ffi.py", line [26](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:27), in <module>
    libarchive = ctypes.cdll.LoadLibrary(libarchive_path)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\ctypes\__init__.py", line 460, in LoadLibrary
    return self._dlltype(name)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\ctypes\__init__.py", line 379, in __init__
    self._handle = _dlopen(self._name, mode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [WinError 1[27](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:28)] The specified procedure could not be found
```
Here is a
[link](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345)
to the full log with the error.
github-actions bot added a commit that referenced this pull request Apr 4, 2025
@github-actions
Pin libxml2 version to 2.13.7 (#2409)
9b64bf8 
This PR pins `libxml2` version to `2.13.7` due to libs dependency issue
with `2.14.0` version as reported on
[#146](conda-forge/libxml2-feedstock#146).

Without that change the conda package can not be build through GitHub
action, since `conda-build` raises error:
```python
Traceback (most recent call last):
  File "C:\Users\runneradmin\miniconda3\envs\build\Scripts\conda-build-script.py", line 6, in <module>
    from conda_build.cli.main_build import execute
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\cli\main_build.py", line 19, in <module>
    from .. import api, build, source, utils
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\api.py", line [24](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:25), in <module>
    from .config import DEFAULT_PREFIX_LENGTH as _prefix_length
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\config.py", line 28, in <module>
    from .utils import (
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\conda_build\utils.py", line 51, in <module>
    import libarchive
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\__init__.py", line 1, in <module>
    from .entry import ArchiveEntry
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\entry.py", line 6, in <module>
    from . import ffi
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\site-packages\libarchive\ffi.py", line [26](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:27), in <module>
    libarchive = ctypes.cdll.LoadLibrary(libarchive_path)
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\ctypes\__init__.py", line 460, in LoadLibrary
    return self._dlltype(name)
           ^^^^^^^^^^^^^^^^^^^
  File "C:\Users\runneradmin\miniconda3\envs\build\Lib\ctypes\__init__.py", line 379, in __init__
    self._handle = _dlopen(self._name, mode)
                   ^^^^^^^^^^^^^^^^^^^^^^^^^
OSError: [WinError 1[27](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345#step:8:28)] The specified procedure could not be found
```
Here is a
[link](https://github.com/IntelPython/dpnp/actions/runs/14267019048/job/39991206345)
to the full log with the error. 073a86c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shssf shssf shssf left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@densmirn @shssf