Workaround to dpnp.allclose() #1568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
|
@vlad-perevezentsev can you please rebase this branch on top of master to remove duplicate changes to cmake scripts? |
oleksandr-pavlyk
approved these changes
Sep 22, 2023
vlad-perevezentsev
force-pushed
the
workaround_allcloce
branch
from
957bc2e to
6703eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a problem with
std::infcheck that does not work on linux CPU.It suggested change provides workaround to reliably detect positive and negative infinity values.
These changes should be removed when CMPLRLLVM-51856 is resolved
In addition I unskipped tests for dpnp.allclose on CPU. This should have been done in #1536