Skip to content

use a seed for random input numbers in tests #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 17, 2024
Merged

use a seed for random input numbers in tests #1716

merged 3 commits into from
Feb 17, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Feb 16, 2024

In this PR, a seed is used to generate random input numbers in test suite for reproducibility of tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Feb 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Base automatically changed from matmul_cupy_test to master February 16, 2024 17:28
@vtavana
add gen_seed
16b96f2 
change seed
@vtavana vtavana marked this pull request as ready for review February 17, 2024 00:18
@vtavana vtavana requested a review from antonwolfy February 17, 2024 00:18
antonwolfy
antonwolfy approved these changes Feb 17, 2024
View reviewed changes
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vtavana

@antonwolfy antonwolfy merged commit f33ef19 into master Feb 17, 2024
@antonwolfy antonwolfy deleted the add_seed_to_tests branch February 17, 2024 13:14
github-actions bot added a commit that referenced this pull request Feb 17, 2024
@github-actions
use a seed for random input numbers in tests (#1716)
b8c7c87 
* add gen_seed

change seed

* use setup_method

* remove duplicates f33ef19
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Feb 17, 2024
@github-actions
use a seed for random input numbers in tests (IntelPython#1716)
f4e6cbe 
* add gen_seed

change seed

* use setup_method

* remove duplicates f33ef19
github-actions bot added a commit to step-security-bot/dpnp that referenced this pull request Feb 17, 2024
@github-actions
use a seed for random input numbers in tests (IntelPython#1716)
3da9bf5 
* add gen_seed

change seed

* use setup_method

* remove duplicates f33ef19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonwolfy antonwolfy antonwolfy approved these changes

Assignees

@vtavana vtavana

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtavana @antonwolfy