Skip to content

Pin conda-build to latest version (24.1.2) #1721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 19, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Feb 19, 2024

This PR removes pinning on previous version of conda-build introduced in #1678 and moves forward to the latest available version of conda-build=24.1.2, since it includes the fix now for nonzero exitcode on success.
Additionally PR enables conda-index package instead of deprecated one from conda-build package.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Feb 19, 2024
Copy link
Contributor

github-actions bot commented Feb 19, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit a100705 into master Feb 19, 2024
@antonwolfy antonwolfy deleted the update_conda_build_version branch February 19, 2024 17:35
github-actions bot added a commit that referenced this pull request Feb 19, 2024
* Pin conda-build to latest version (24.1.2)

* Use conda-index package instead of conda-build a100705
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants