Skip to content

Remove step with installing opencl_rt #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Mar 19, 2024

The PR proposes to get rid of installation of opencl_rt package before running tests for Windows.

The step was previously added as a workaround and isn't required anymore, since fully covered by dependent conda packages.
Removing the step will slightly speed up Conda package action.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Mar 19, 2024
Copy link
Contributor

github-actions bot commented Mar 19, 2024

View rendered docs @ https://intelpython.github.io/dpnp/pull//index.html

@vlad-perevezentsev vlad-perevezentsev self-requested a review March 19, 2024 11:55
Copy link
Collaborator

@vlad-perevezentsev vlad-perevezentsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thank you @antonwolfy

@antonwolfy antonwolfy merged commit 668e7ef into master Mar 19, 2024
@antonwolfy antonwolfy deleted the remove-installing-opencl-rt branch March 19, 2024 13:11
github-actions bot added a commit to antonwolfy/dpnp that referenced this pull request Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants