Skip to content

update BLAS extension routines #1884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 17, 2024
Merged

update BLAS extension routines #1884

merged 2 commits into from
Jun 17, 2024

Conversation

vtavana
Copy link
Collaborator

@vtavana vtavana commented Jun 15, 2024

In this PR, the following changes are made in BLAS extension part of the code

  • function arguments are updated to pass by reference where appropriate.
  • constant argument are explicitly specified using const keyword.
  • naming convention for namespaces are modified to align with recent changes in vm extension.
  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@vtavana vtavana self-assigned this Jun 15, 2024
Copy link
Contributor

github-actions bot commented Jun 15, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@vtavana vtavana marked this pull request as ready for review June 15, 2024 17:08
Copy link
Contributor

@antonwolfy antonwolfy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vtavana, thank you for improving code quality!

@antonwolfy antonwolfy merged commit a813fae into master Jun 17, 2024
47 of 56 checks passed
@antonwolfy antonwolfy deleted the update_backend branch June 17, 2024 11:10
github-actions bot added a commit that referenced this pull request Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants