Update lapack syevd/heevd implementations #1891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
reviewed
Jun 27, 2024
antonwolfy
reviewed
Jun 27, 2024
antonwolfy
approved these changes
Jul 12, 2024
There was a problem hiding this comment.
Thank you @vlad-perevezentsev. The code is much more structed now.
I have only minor comment.
github-actions bot
added a commit
that referenced
this pull request
Jul 12, 2024
* Use dispatch_table for syevd * Implement common logic for lapack syevd/heevd * Remove junk code * Add source files for syevd and heevd --------- Co-authored-by: Anton <[email protected]> 8ac7f88
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suggests implementing a common
evd_func(Eigen Vectors Divide) function instead ofsyevdandheevdto reduce code duplicationAdditionally add
CheckWritablecheck and implement queue passing by reference