Use INTEL_MKL_VERSION flag
#2035
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
vtavana
requested review from
antonwolfy,
npolina4 and
vlad-perevezentsev
as code owners
antonwolfy
reviewed
Sep 14, 2024
There was a problem hiding this comment.
The issue looks resolved now. Tnank you @vtavana.
Please add a note to changelog, since the PR will be backported to maintenance/0.16.x branch.
antonwolfy
pushed a commit
that referenced
this pull request
Sep 15, 2024
antonwolfy
added a commit
that referenced
this pull request
Sep 16, 2024
antonwolfy
added a commit
that referenced
this pull request
Sep 16, 2024
* Fix failing test for `dpnp.append` when no fp64 for device (#2034) * Fix test for dpnp.append with was failing with no fp64 support * Update docstring for dpnp.append and dpnp.asarray_chkfinite --------- Co-authored-by: vtavana <[email protected]> * Update CHANGELOG * Use Pybind11 2.13.6 to build dpnp (#2041) Co-authored-by: vtavana <[email protected]> * Update CHANGELOG * Use `INTEL_MKL_VERSION` flag (#2035) * use MKL_VERSION flag * update CHANGELOG.md * Backport gh-2030 (#2046) * Implement `dpnp.rot90` and `dpnp.resize` (#2030) * add rot90 and resize * fix docstring * address comments --------- Co-authored-by: Anton <[email protected]> * Update changelog --------- Co-authored-by: vtavana <[email protected]> --------- Co-authored-by: vtavana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In continuation of #2025, the code is modified to use
INTEL_MKL_VERSIONflag to determine which version of MKL is installed and being used and accordingly run the proper part of the code.