Skip to content

Enable the whole scope of indexing tests in public CI #2049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 16, 2024
Merged

Enable the whole scope of indexing tests in public CI #2049

merged 1 commit into from
Sep 16, 2024

Conversation

antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Sep 16, 2024 •
edited
Loading

The PR proposes to enable all tests scopes from indexing_tests folder in public CI.
While tests/third_party/cupy/indexing_tests/test_generate.py is updated with the recent latest changes in third party tests.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@antonwolfy antonwolfy self-assigned this Sep 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 16, 2024 •
edited
Loading

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review September 16, 2024 15:12
vtavana
vtavana approved these changes Sep 16, 2024
View reviewed changes
Copy link
Collaborator

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 9714cf3 into master Sep 16, 2024
40 of 46 checks passed
@antonwolfy antonwolfy deleted the enable-more-tests-in-public-ci branch September 16, 2024 15:34
github-actions bot added a commit that referenced this pull request Sep 16, 2024
@github-actions
Enable the whole scope of indexing tests in public CI (#2049) 9714cf3
818717b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtavana vtavana vtavana approved these changes

@npolina4 npolina4 Awaiting requested review from npolina4

@vlad-perevezentsev vlad-perevezentsev Awaiting requested review from vlad-perevezentsev vlad-perevezentsev is a code owner

Assignees

@antonwolfy antonwolfy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonwolfy @vtavana