Limit a test run for roll function by NumPy version
#2092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
antonwolfy
force-pushed
the
no-exception-from-np.roll-since-2.1.2-version
branch
from
b17ab53 to
eaa7f2f
Compare
vlad-perevezentsev
approved these changes
Oct 7, 2024
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
github-actions bot
added a commit
that referenced
this pull request
Oct 7, 2024
* Update third party test failing since numpy 2.1.2 * Applied pre-commit formatting 12133a3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was issue#27431 resolved since NumPy 2.1.2 which allows unsigned shift argument value for
numpy.roll.Thus
test_roll_invalid_shifttest fromtests/third_party/cupy/manipulation_tests/test_rearrange.py::TestRollTypeErrorscope will no raiseTypeErrorin that case.dpctl#1857 is filed to address the same issue in dpctl.
Meanwhile that PR proposes to limit the test run by
numpy<2.1.2condition and to update the test again once the issue is resolved by dpctl.