Workaround issue with lcm kernel on Windows #2100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
approved these changes
Oct 11, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 12, 2024
* W/a issue with lcm kernel on Windows * Update TODO comment to point on Jira ticket with issue 808a6f2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation of
dpnp.lcmfunction was based ononeapi::dpl::lcmfunction called inside the kernel.Due to some unclear reason the function returns incorrect values for signed input types.
The PR propose to implement the workaround with lcm kernel written through
oneapi::dpl::gcdexplicitly to unblock the internal CI/CD.