Add implementation of dpnp.ldexp #2110
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
View rendered docs @ https://intelpython.github.io/dpnp/index.html |
antonwolfy
force-pushed
the
impl-ldexp
branch
from
1b6c7e7 to
341867a
Compare
antonwolfy
force-pushed
the
impl-ldexp
branch
from
341867a to
9fcca48
Compare
antonwolfy
requested review from
npolina4,
vlad-perevezentsev and
vtavana
as code owners
vtavana
reviewed
Oct 16, 2024
Co-authored-by: vtavana <[email protected]>
vlad-perevezentsev
approved these changes
Oct 18, 2024
github-actions bot
added a commit
that referenced
this pull request
Oct 18, 2024
* Add _ldexp to ufunc extension * Add dpnp.ldexp to python interface * Enable third party test * Add CFD tests * Enable umath tests * Add support of `weak_type_resolver` keyword to DPNPBinaryFunc class * Add more integer type to matrix * Proper handling of large exponent values * Add more tests * Add a test with scalar exp of bool type * Fix exception raised in numpy.ldexp by test_overflow * Mute tests with unsupported loop for numpy.ldexp * Apply suggestions from code review Co-authored-by: vtavana <[email protected]> * State limitations for real, imag, rint, round, angle, fabs, fix functions * Remove limitation block for angle, real, round functions * Align real and imag signatures with ones from dpctl * Add missing description of deg keyword to dpnp.angle * State expected dtypes for input arrays * Fix typos in limitations --------- Co-authored-by: vtavana <[email protected]> da64a4b
vtavana
added a commit
that referenced
this pull request
Oct 28, 2024
* Add _ldexp to ufunc extension * Add dpnp.ldexp to python interface * Enable third party test * Add CFD tests * Enable umath tests * Add support of `weak_type_resolver` keyword to DPNPBinaryFunc class * Add more integer type to matrix * Proper handling of large exponent values * Add more tests * Add a test with scalar exp of bool type * Fix exception raised in numpy.ldexp by test_overflow * Mute tests with unsupported loop for numpy.ldexp * Apply suggestions from code review Co-authored-by: vtavana <[email protected]> * State limitations for real, imag, rint, round, angle, fabs, fix functions * Remove limitation block for angle, real, round functions * Align real and imag signatures with ones from dpctl * Add missing description of deg keyword to dpnp.angle * State expected dtypes for input arrays * Fix typos in limitations --------- Co-authored-by: vtavana <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR proposes to add implementation of
dpnp.ldexpfunction.The new dedicated
_ldexpfunction are added to_ufunc_implpybind11 extension.All the required tests are implemented to cover the new functions. Internal
DPNPBinaryFuncclass is extended to supportweak_type_resolvercallback.